Skip to content

Qualcomm AI Engine Direct - Improve CLI tools #16012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2025
Merged

Qualcomm AI Engine Direct - Improve CLI tools #16012

merged 3 commits into from
Dec 2, 2025
+187 −42

Conversation

@chenweng-quic
Copy link
Collaborator

@chenweng-quic chenweng-quic commented Dec 1, 2025

Summary

  • Update CLI tool to support input list assignment
    (e.g., input1:=input1.raw input2:=input2.raw)
  • Update CLI tool output structure
    origin: outputs/output_0_0.pt outputs/outupt_1_0.pt
    new: outputs/Result_0/output_0.pt output/Result_1/output_0.pt

Motivation

This PR facilitates QC CI/QA teams to validate the QNN output with goldens.

Test plan

python ${EXECUTORCH_ROOT}/backends/qualcomm/tests/test_qnn_delegate.py -k TestUtilsScript.test_cli_with_input_list_assignment --model <soc_model> --build_folder <build_folder> --host <host> --device <device>

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16012

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 6 Pending

As of commit 1d29be5 with merge base 1864fb0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2025
cccclai
cccclai approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you rebase to trigger CI?

cccclai
cccclai reviewed Dec 2, 2025
View reviewed changes
examples/qualcomm/util_scripts/cli.py
from torchao.quantization import pt2e
from torchao.quantization.pt2e.quantize_pt2e import convert_pt2e, prepare_pt2e

INPUT_ORDER = "input_order"
Copy link
Contributor

@cccclai cccclai Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, it seems this cli tool is for QA and not necessarily for community users, can we document it?

Copy link
Collaborator Author

@chenweng-quic chenweng-quic Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai cccclai merged commit 3b1aeda into pytorch:main Dec 2, 2025
139 of 141 checks passed
AdrianLundell pushed a commit to AdrianLundell/executorch that referenced this pull request Dec 2, 2025
@chenweng-quic @AdrianLundell
Qualcomm AI Engine Direct - Improve CLI tools (pytorch#16012)
9c8cadb 
### Summary
- Update CLI tool to support input list assignment
  (e.g., input1:=input1.raw input2:=input2.raw)
- Update CLI tool output structure
  origin: outputs/output_0_0.pt outputs/outupt_1_0.pt
  new: outputs/Result_0/output_0.pt output/Result_1/output_0.pt

### Motivation
This PR facilitates QC CI/QA teams to validate the QNN output with
goldens.

### Test plan
```
python ${EXECUTORCH_ROOT}/backends/qualcomm/tests/test_qnn_delegate.py -k TestUtilsScript.test_cli_with_input_list_assignment --model <soc_model> --build_folder <build_folder> --host <host> --device <device>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenweng-quic @cccclai